Skip to content

feat: add i32 return type for length functions #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richtia wants to merge 3 commits into from
Closed

feat: add i32 return type for length functions #606

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a83d7e2
feat: add i32 return type for length functions
richtia Feb 23, 2024
9a235c9
fix: add new function for 32 bit variation
richtia Feb 26, 2024
4660034
Merge branch 'main' into update_lenth_funcs
jacques-n Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions extensions/functions_string.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,6 +1093,23 @@ scalar_functions:
- value: "fixedchar<L1>"
name: "input"
return: i64
-
name: char_length_32
description: >-
Return the number of characters in the input string. The length includes trailing spaces.
Copy link
Copy Markdown
Contributor

@jacques-n jacques-n Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is characters mean code points?

Copy link
Copy Markdown
Contributor

@jacques-n jacques-n Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @richtia for clarity on what character means. In some system this means bytes. In some system it means utf8 codepoints.

impls:
- args:
- value: "string"
name: "input"
return: i32
- args:
- value: "varchar<L1>"
name: "input"
return: i32
- args:
- value: "fixedchar<L1>"
name: "input"
return: i32
-
name: bit_length
description: Return the number of bits in the input string.
Expand All @@ -1109,6 +1126,22 @@ scalar_functions:
- value: "fixedchar<L1>"
name: "input"
return: i64
-
name: bit_length_32
description: Return the number of bits in the input string.
impls:
- args:
- value: "string"
name: "input"
return: i32
- args:
- value: "varchar<L1>"
name: "input"
return: i32
- args:
- value: "fixedchar<L1>"
name: "input"
return: i32
-
name: octet_length
description: Return the number of bytes in the input string.
Expand All @@ -1125,6 +1158,22 @@ scalar_functions:
- value: "fixedchar<L1>"
name: "input"
return: i64
-
name: octet_length_32
description: Return the number of bytes in the input string.
impls:
- args:
- value: "string"
name: "input"
return: i32
- args:
- value: "varchar<L1>"
name: "input"
return: i32
- args:
- value: "fixedchar<L1>"
name: "input"
return: i32
-
name: regexp_replace
description: >-
Expand Down