Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/fs-core/src/Superblock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,20 @@ export class Superblock {
this.emit(new FsEvent(FsEventType.DELETE, link.steps, link.getNode(), link));
}

private _releaseUnlinkedTree(link: Link) {
const node = link.getNode();
if (node.isDirectory()) {
for (const [name, child] of link.children.entries()) {
if (child && name !== '.' && name !== '..') this._releaseUnlinkedTree(child);
}
node.nlink = 0;
} else {
node.nlink--;
}
// Open files retain their Node and buffer independently of the inode table.
if (node.nlink <= 0) this.deleteNode(node);
}

private newInoNumber(): number {
const releasedFd = this.releasedInos.pop();

Expand Down Expand Up @@ -840,7 +854,7 @@ export class Superblock {
const link = this.getLinkAsDirOrThrow(filename, 'rmdir');
if (link.length && !recursive) throw createError(ERROR_CODE.ENOTEMPTY, 'rmdir', filename);
this._emitDeleteRecursive(link);
this.deleteLink(link);
if (this.deleteLink(link)) this._releaseUnlinkedTree(link);
};

public readonly rm = (filename: string, force: boolean = false, recursive: boolean = false): void => {
Expand All @@ -856,7 +870,7 @@ export class Superblock {
// TODO: Node reports the failing `unlink`/`rmdir` syscall here; `rm` is not a libuv request.
if (!link.parent?.getNode().canWrite()) throw createError(ERROR_CODE.EACCES, 'rm', filename);
this._emitDeleteRecursive(link);
this.deleteLink(link);
if (this.deleteLink(link)) this._releaseUnlinkedTree(link);
};

protected closeFile(file: File) {
Expand Down
92 changes: 92 additions & 0 deletions packages/fs-node/src/__tests__/volume/rmInodes.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
import { create } from '../util';

describe('removal inode lifecycle', () => {
it('releases the inode after removing a file', () => {
const vol = create({ '/file': 'content' });
const ino = vol.statSync('/file').ino;
vol.rmSync('/file');
expect(vol._core.inodes[Number(ino)]).toBeUndefined();
expect(vol._core.releasedInos).toContain(ino);
expect(Object.keys(vol._core.inodes)).toHaveLength(1);
});

it.each(['rm', 'rmdir'])('releases every inode in a subtree removed with %s', method => {
const vol = create({ '/tree/nested/file': 'content', '/tree/other': 'other' });
const root = vol._core.root.getNode();
if (method === 'rm') vol.rmSync('/tree', { recursive: true });
else vol.rmdirSync('/tree', { recursive: true });
expect(Object.values(vol._core.inodes)).toEqual([root]);
expect(new Set(vol._core.releasedInos).size).toBe(4);
expect(vol.readdirSync('/')).toEqual([]);
});

it('releases an empty directory inode', () => {
const vol = create({});
vol.mkdirSync('/empty');
vol.rmdirSync('/empty');
expect(Object.keys(vol._core.inodes)).toHaveLength(1);
});

it('keeps an external hard link and removes each internal hard link once', () => {
const vol = create({ '/tree/file': 'content' });
vol.linkSync('/tree/file', '/tree/alias');
vol.linkSync('/tree/file', '/outside');
const ino = Number(vol.statSync('/outside').ino);
vol.rmSync('/tree', { recursive: true });
expect(vol.readFileSync('/outside', 'utf8')).toBe('content');
expect(vol.statSync('/outside').nlink).toBe(1);
expect(vol._core.inodes[ino]).toBeDefined();
vol.unlinkSync('/outside');
expect(vol._core.inodes[ino]).toBeUndefined();
expect(vol._core.releasedInos.filter(value => value === ino)).toHaveLength(1);
});

it('releases an inode shared by two links inside the removed subtree only once', () => {
const vol = create({ '/tree/file': 'content' });
vol.linkSync('/tree/file', '/tree/alias');
const ino = Number(vol.statSync('/tree/file').ino);
vol.rmSync('/tree', { recursive: true });
expect(vol._core.inodes[ino]).toBeUndefined();
expect(vol._core.releasedInos.filter(value => value === ino)).toHaveLength(1);
});

it.each([false, true])('preserves an open file after removal (recursive: %s)', recursive => {
const vol = create({ '/tree/file': 'content' });
const fd = vol.openSync('/tree/file', 'r');
const ino = Number(vol.fstatSync(fd).ino);
try {
vol.rmSync(recursive ? '/tree' : '/tree/file', { recursive });
expect(vol._core.inodes[ino]).toBeUndefined();
expect(vol.fstatSync(fd).nlink).toBe(0);
expect(vol.readFileSync(fd, 'utf8')).toBe('content');
vol.writeFileSync('/replacement', 'different');
expect(vol.fstatSync(fd).size).toBe(7);
} finally {
vol.closeSync(fd);
}
expect(Object.keys(vol._core.fds)).toHaveLength(0);
});

it('releases a symlink in a removed subtree without removing its target', () => {
const vol = create({ '/outside': 'content' });
vol.mkdirSync('/tree');
vol.symlinkSync('/outside', '/tree/link');
const ino = Number(vol.lstatSync('/tree/link').ino);
vol.rmSync('/tree', { recursive: true });
expect(vol._core.inodes[ino]).toBeUndefined();
expect(vol.readFileSync('/outside', 'utf8')).toBe('content');
expect(Object.keys(vol._core.inodes)).toHaveLength(2);
});

it('reuses inode numbers across repeated create/remove cycles', () => {
const vol = create({});
for (let round = 0; round < 5; round++) {
vol.mkdirSync('/tree');
for (let i = 0; i < 10; i++) vol.writeFileSync(`/tree/file${i}`, Buffer.alloc(1024));
vol.rmSync('/tree', { recursive: true });
expect(Object.keys(vol._core.inodes)).toHaveLength(1);
expect(vol._core.releasedInos).toHaveLength(11);
expect(Object.keys(vol._core.fds)).toHaveLength(0);
}
});
});