Repository navigation
Conversation
…Entry()`
Node.js 25 removed the `recursive` option of `fs.rmdir()` (DEP0147) and
now throws ERR_INVALID_ARG_VALUE whenever the option is present, even
when it is `false`. `removeEntry()` passed it for every folder, so
removing any folder through `nodeToFsa(fs, ...)` failed on Node.js 25+.
Use `rm(path, { recursive: true })` for recursive removal and plain
`rmdir(path)` otherwise.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Node.js 25 and later,
removeEntry()fails for every folder when the adapter wraps the realfsmodule (nodeToFsa(fs, ...)as in the README):Node.js 25 moved DEP0147 to end-of-life.
fs.rmdir()now throws whenever therecursiveoption is present, even when it isfalse.removeEntry()always passed{ recursive }.The existing tests use a memfs volume, which still accepts the option, so CI didn't catch it.
Changes:
rm(path, { recursive: true }). Non-recursive removal callsrmdir(path)without options, so a non-empty folder still fails withENOTEMPTY, which maps toInvalidModificationError.removeEntry()against the realfsin a temp dir: an empty folder, a non-empty folder withoutrecursive, and withrecursive. Without the fix they fail on Node.js 26, and they pass on 24 and 26 with it.I used Claude Code to write this change.