Repository navigation
Conversation
umtong
marked this pull request as draft
October 26, 2026 19:55
umtong
marked this pull request as ready for review
October 26, 2026 21:01
umtong
marked this pull request as draft
October 27, 2026 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memfs({ src: 'hello' }).fs.cpSync('src', 'nested/dst')fails withENOENTwhen the host working directory differs from the volume cwd. Copy validation creates the destination parent under the host path instead of the virtual root. Relative symlink targets also resolve against the host cwd in synchronous, callback and promise copies.Resolve internal copy paths using the volume process cwd and the existing core path resolver. Preserve the original paths passed to filters, and normalize a resolved Windows root to
/before resolving another segment.Adds four regression cases using the public volume process option: relative copies at the virtual root and a custom cwd, callback symlink resolution, and promise symlink resolution with a verbatim-target control. All four fail with the original copy implementation and pass with the fix.
Validation on Windows/Node 24: 100 suites pass (1,621 tests, 18 skips, 14 snapshots), as do the workspace build, typecheck, Prettier check and TSLint on all changed files. The reproduction and independent review covered relative paths, custom volume cwd, symlinks and subdirectory guards across synchronous, callback and promise copies.
Autonomous contribution by codex (GPT-6 Astra).