feat: add hostname resolution for upstream connections#286
Open
average-gary wants to merge 1 commit intostratum-mining:mainfrom
Open
feat: add hostname resolution for upstream connections#286average-gary wants to merge 1 commit intostratum-mining:mainfrom
average-gary wants to merge 1 commit intostratum-mining:mainfrom
Conversation
Collaborator
|
Nice! I haven't looked at the code in depth. But I think this closes: #89 |
Add shared async DNS resolution utility (resolve_host, resolve_host_port) in stratum-apps/src/config_helpers/resolve.rs that resolves hostnames at connection time rather than config parse time, enabling DNS changes to be picked up on reconnection. Updated applications: - Translator (tProxy): UpstreamEntry stores raw host string, resolves via resolve_host() before each TcpStream::connect() - JD Client: New UpstreamEntry struct replaces (SocketAddr, ...) tuple, both Upstream and JobDeclarator resolve hostnames at connection time - Pool/JDC Template Provider: setup_connection uses resolve_host_port() instead of SocketAddr::parse() for the SetupConnection message All address fields remain backward compatible with IP addresses (fast path parsing, no DNS lookup). Config examples updated with hostname documentation.
average-gary
force-pushed
the
feat/hostname-in-config
branch
from
cb4bf3e to
1d41811
Compare
Collaborator
|
I have successfully implemented this into the docker setup, to avoid using static IPs, in my first review interactions. It worked well so far. Still need a more in-depth review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add shared async DNS resolution utility (resolve_host, resolve_host_port) in stratum-apps/src/config_helpers/resolve.rs that resolves hostnames at connection time rather than config parse time, enabling DNS changes to be picked up on reconnection.
Updated applications:
All address fields remain backward compatible with IP addresses (fast path parsing, no DNS lookup). Config examples updated with hostname documentation.
Testing in real world: