Open
Conversation
300f7ff to
485b030
Compare
Member
|
Why do we need this change? Do we have some data which demonstrates how this change is improving performances of our apps? |
Collaborator
Author
Yes, it’s a memory allocator that’s better suited to our use case: long-running processes with frequent allocations, high concurrency, and a need for consistent latency. The default global allocator isn’t ideal here, as it tends to increase fragmentation and introduce global locking during allocations. I will run benchmarks and share the results here. |
e2cd179 to
fb6d404
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR switches the binaries to use mimalloc instead of the default glibc allocator, which can exhibit higher fragmentation and contention under our workload.