fix mismatches in channel_bit and message_type according to the specs#2095
Open
lucasbalieiro wants to merge 3 commits intostratum-mining:mainfrom
Open
fix mismatches in channel_bit and message_type according to the specs#2095lucasbalieiro wants to merge 3 commits intostratum-mining:mainfrom
channel_bit and message_type according to the specs#2095lucasbalieiro wants to merge 3 commits intostratum-mining:mainfrom
Conversation
Member
|
we'll have to bump
|
This was referenced Feb 20, 2026
lucasbalieiro
force-pushed
the
fix-reconnect-bit-definition
branch
from
8f9c031 to
8a353c6
Compare
lucasbalieiro
changed the title
CHANNEL_BIT_RECONNECTchannel_bit and message_type according to the specs
lucasbalieiro
force-pushed
the
fix-reconnect-bit-definition
branch
from
8a353c6 to
c146bcf
Compare
Member
|
as we expanded the scope on this PR, we should keep unrelated changes on atomic commits |
…on_messages_sv2` and major bump `mining_sv2`
…` and major bump `job_declaration_sv2`
lucasbalieiro
force-pushed
the
fix-reconnect-bit-definition
branch
from
c146bcf to
87a3c5c
Compare
Collaborator
Author
GitGab19
reviewed
Feb 23, 2026
GitGab19
approved these changes
Feb 26, 2026
plebhash
reviewed
Feb 27, 2026
| pub const MESSAGE_TYPE_PUSH_SOLUTION: u8 = 0x60; | ||
|
|
||
| // In the Job Declaration protocol, the `channel_msg` bit is always unset, | ||
| // except for `SUBMIT_SOLUTION_JD`, which requires a specific channel reference. |
Member
There was a problem hiding this comment.
Suggested change
| // except for `PUSH_SOLUTION`, which requires a specific channel reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2094
MAJOR BUMP
mining_sv2.MAJOR BUMP
job_declaration_sv2