Add to_le_bytes and to_be_bytes helpers to U256 (Fixes #2065)#2080
Open
therohityadav wants to merge 1 commit intostratum-mining:mainfrom
Open
Add to_le_bytes and to_be_bytes helpers to U256 (Fixes #2065)#2080therohityadav wants to merge 1 commit intostratum-mining:mainfrom
therohityadav wants to merge 1 commit intostratum-mining:mainfrom
Conversation
therohityadav
force-pushed
the
feature/issue-2065-clean
branch
from
1bc68bc to
d980e5e
Compare
therohityadav
force-pushed
the
feature/issue-2065-clean
branch
from
d980e5e to
0745282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
to_le_bytesandto_be_byteshelper methods to theU256struct, resolving issue #2065.These helpers simplify converting
U256to byte arrays (little-endian and big-endian) and remove the need for repetitivetry_into().expect(...)calls throughout the codebase.Changes
to_le_bytes(&self) -> [u8; 32]to_be_bytes(&self) -> [u8; 32]test_u256_endiannessunit test to verify correct byte order.Verification
cargo test -p binary_sv2(All tests passed locally).