Optimize Extranonce cloning in hot path (Fixes #2076)#2079
Open
therohityadav wants to merge 1 commit intostratum-mining:mainfrom
Open
Optimize Extranonce cloning in hot path (Fixes #2076)#2079therohityadav wants to merge 1 commit intostratum-mining:mainfrom
therohityadav wants to merge 1 commit intostratum-mining:mainfrom
Conversation
- Implemented AsRef for Extranonce struct. - Refactored validate_share to use extend_from_slice instead of clone and extend. - This reduces unnecessary allocations during share validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #2076 by optimizing memory usage during share validation.
Changes
AsRef<[u8]>for theExtranoncestruct insv2/subprotocols/mining/src/lib.rs.validate_shareinsv2/channels-sv2/src/server/extended.rsto useextend_from_sliceinstead ofclone()+extend().Impact
This optimization removes unnecessary heap allocations on the "hot path" of share validation, improving performance for the mining server.
Verification
cargo test -p mining_sv2(Verified trait implementation)cargo test -p channels_sv2(Verified share validation logic remains correct)cargo test(Verified all tests pass across the workspace)