Add a translator from SMT.Term to SMTDDM.Term #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a translator from SMT.Term to SMTDDM.Term, and also has a small code snippet that prints the SMTDDM.Term into the format. There are missing features, which will be addressed in the following commits. - Whitespaces must exist between the printed subterms(!) - Option types, triggers, real-number/bit-vector constants are left as unimplemented.
aqjune-aws
commented
Oct 31, 2025
aqjune-aws
requested review from
MikaelMayer,
andrewmwells-amazon,
atomb,
joehendrix and
shigoel
as code owners
aqjune-aws
commented
Nov 6, 2025
aqjune-aws
commented
Nov 6, 2025
aqjune-aws
commented
Nov 6, 2025
aqjune-aws
commented
Nov 6, 2025
aqjune-aws
commented
Nov 6, 2025
joscoh
previously approved these changes
Jan 6, 2026
joscoh
previously approved these changes
Jan 8, 2026
MikaelMayer
previously approved these changes
Jan 8, 2026
Contributor
MikaelMayer
left a comment
MikaelMayer
left a comment
There was a problem hiding this comment.
I feel like we will really need sooner or later SpaceSepBy in the DDM but otherwise this is good for now.
joehendrix
previously approved these changes
Jan 8, 2026
shigoel
previously approved these changes
Jan 8, 2026
MikaelMayer
dismissed stale reviews from joehendrix, shigoel, joscoh, and themself
via
e9e5fa1
MikaelMayer
approved these changes
Jan 9, 2026
joehendrix
approved these changes
Jan 9, 2026
shigoel
approved these changes
Jan 9, 2026
atomb
approved these changes
Jan 9, 2026
Contributor
Author
|
Thank you all! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
get-optionSMT command and relevant syntax categories (mentioned in the previous pull request)..realconstructor of the old SMT Term, fromStringtoDecimal.After 3, I checked the generated .smt2 files at
vcs/dir, and confirmed that they are equivalent modulo spaces! :)There are a few features in the string converters that are unimplemented; they will be added later when Encoder.lean uses the DDM string converter more.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.