Skip to content

feat: initial work on accessibility settings#579

Open
reeesespuffs wants to merge 17 commits into
mainfrom
feat/accessibility
Open

feat: initial work on accessibility settings#579
reeesespuffs wants to merge 17 commits into
mainfrom
feat/accessibility

Conversation

@reeesespuffs

@reeesespuffs reeesespuffs commented Dec 30, 2025

Copy link
Copy Markdown
Member

Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>

@insertish insertish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I noticed

Comment thread packages/client/components/app/interface/settings/user/Accessibility.tsx Outdated
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
@reeesespuffs reeesespuffs enabled auto-merge (squash) January 28, 2026 22:57
@insertish

Copy link
Copy Markdown
Member

ugh, why does it feel the need to add line numbers (referring to conflicts on PR)

@github-actions github-actions Bot force-pushed the feat/accessibility branch 2 times, most recently from 2ea6729 to 255a599 Compare March 10, 2026 10:01
@github-actions github-actions Bot force-pushed the feat/accessibility branch from 255a599 to 6e86642 Compare March 10, 2026 10:02
mihaicm93
mihaicm93 previously approved these changes Mar 10, 2026
@reeesespuffs reeesespuffs removed the request for review from insertish March 10, 2026 10:12
@reeesespuffs reeesespuffs dismissed insertish’s stale review March 10, 2026 10:13

requested changes were resolved

@mihaicm93 mihaicm93 dismissed their stale review March 10, 2026 12:49

Stuck checks test

@mihaicm93 mihaicm93 disabled auto-merge March 10, 2026 12:50
@mihaicm93 mihaicm93 enabled auto-merge (squash) March 10, 2026 12:51
@ThomasJRyan ThomasJRyan requested a review from infi March 12, 2026 15:07
@chrishultin chrishultin disabled auto-merge March 13, 2026 00:52
@ThomasJRyan

Copy link
Copy Markdown
Contributor

@reeesespuffs can you add in some screenshots of any UI changes you've made?

@ThomasJRyan ThomasJRyan added the ux review This needs UX review label Mar 13, 2026
reeesespuffs and others added 3 commits March 12, 2026 23:35
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
@reeesespuffs

Copy link
Copy Markdown
Member Author

@insertish the conflicts have been resolved, unfortunately some of the checks are stuck so this PR will need to be merged by you

@Pecacheu

Copy link
Copy Markdown
Contributor

Love the look of this, however correct me if I'm wrong but I don't see anything in the actual code that makes the send message button always appear on mobile as the tooltip claims (and that isn't the current behavior of the current release). I'd be happy to add that to #835 though, it makes a lot of sense.

@insertish

Copy link
Copy Markdown
Member

Please drop i18n/catalogs from the PR, workflow has been changed, sorry for the inconvenience 🙂

@insertish insertish requested review from a team as code owners May 31, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ux review This needs UX review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants