feat: implement server sidebar in EmojiPicker#1250
Conversation
Uses the non-functional server sidebar, and makes it functional. Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
Signed-off-by: AsrayeDev <asrayeofficial@gmail.com>
@Dadadah Managed to adjust it to actually fit the original ten emojis a lot more snugly, as well as did the other thing's you requested. I also noticed the |
|
Looks good, I am concerned the emojis may be too small now, but we'll see what UI/UX thinks. |
| measurements.container.cross / measurements.itemSize.cross, | ||
| ) | ||
| } | ||
| itemSize={{ height: 35, width: 35 }} |
There was a problem hiding this comment.
I agree with @Dadadah that the icons are too small now, but more importantly the new size makes icons blurry on high-DPI displays. The previous icons with a container size of 40x40 rendered at exactly 32x32, of which the full size 128x128 is a multiple. Now with the new container size of 35x35 they are rendering at the bizarre size of 27x27, causing blurriness.
Also you may need to make the entire emoji picker slightly wider to make it fit an exact number of icons edge-to-edge as before, but it sounds like Dadadah would like it a bit wider anyhow: #1255


Uses the non-functional server sidebar, and makes it functional.
(type: [0, 3])to useposition: "absolute"andwidth: "100%". Without this, the virtualizer kept trying to treat the headers like emojis (lol)const COLUMNS = 8;CompositionMediaPicker.tsxchange was needed to prevent the window closing when selecting a serverL:242Closes #979
How was this PR tested?
Screenshots & Screencasts (if appropriate)
EmojiSidebar.mp4
Checklist:
Please declare, if any, LLM usage involved in creating this PR
None
...