Skip to content

fix: rename adslib.so -> AdsLib.so to match upstream library name#531

Open
pbruenn wants to merge 1 commit into
stlehmann:masterfrom
pbruenn:patrickbr/update-adslib
Open

fix: rename adslib.so -> AdsLib.so to match upstream library name#531
pbruenn wants to merge 1 commit into
stlehmann:masterfrom
pbruenn:patrickbr/update-adslib

Conversation

@pbruenn

@pbruenn pbruenn commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The upstream AdsLib project renamed the library output from libadslib.so
to libAdsLib.so in Beckhoff/ADS@ca978d7.

Update all references in documentation, setup.py, and pyads_ex.py to
use the correct case-sensitive library name.

Also bump the adslib submodule to 6788651.

Signed-off-by: Patrick Bruenn p.bruenn@beckhoff.com
Assisted-by: OpenCode:claude-opus-4.6

The upstream AdsLib project renamed the library output from libadslib.so
to libAdsLib.so in Beckhoff/ADS@ca978d7.

Update all references in documentation, setup.py, and pyads_ex.py to
use the correct case-sensitive library name.

Also bump the adslib submodule to 6788651.

Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>
Assisted-by: OpenCode:claude-opus-4.6
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 27457433876

Coverage decreased (-0.02%) to 93.558%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 2 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/pyads/pyads_ex.py 2 91.18%

Coverage Stats

Coverage Status
Relevant Lines: 11580
Covered Lines: 10834
Line Coverage: 93.56%
Coverage Strength: 0.94 hits per line

💛 - Coveralls

@stlehmann stlehmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbruenn Thanks for this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants