feat: make FASTQ analysis optional - #315
Open
adthrasher wants to merge 9 commits into
Open
Conversation
adthrasher
commented
May 18, 2026
6 tasks
Member
Author
|
Fix for GATK4 tests is in #282 |
a-frantz
reviewed
Jul 30, 2026
a-frantz
requested changes
Aug 3, 2026
a-frantz
left a comment
Member
There was a problem hiding this comment.
as discussed over DM, the comments I request be deleted miss the mark. The fact they match the task default is a coincidence; the inputs have reason to be specified here at the workflow level.
Even though specifying here is technically redundant with relying on the default task values, I'd rather explicitly specify them here with the reasoning. Respecifying here at the workflow level is also a safeguard against the default switching out from under us
a-frantz
reviewed
Aug 3, 2026
Co-authored-by: Ari Frantz <ari.frantz@stjude.org>
a-frantz
previously approved these changes
Aug 3, 2026
a-frantz
left a comment
Member
There was a problem hiding this comment.
a take it or leave it doc suggestion, and another less confident thought I had about potential QC docs (tangent from this PR)
Co-authored-by: Ari Frantz <ari.frantz@stjude.org>
a-frantz
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the FASTQ portion of the QC pipeline optional. The default remains to run, but this allows a user to disable the analysis that depends on FASTQ files.
Also contains an off-topic change to add exceptions forThis is now in #317.EmptyOutputsto tasks with no expected outputs, since that rule was added to Sprocket.Before submitting this PR, please make sure:
scripts/ordocker/directories, please ensure any image versions have been incremented accordingly!