fix: respect process umask when creating files - #776
Open
devk0n wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use standard pre-umask creation modes for new files and directories so Oil respects the process umask.
Previously Oil requested:
06440755Because a process umask can only remove permission bits, users with a group-writable umask such as
0002still received0644files and0755directories.This changes the creation modes to:
06660777and allows the operating system to apply the process umask normally.
Example
With:
umask 0002Oil now creates:
06640775With:
umask 0022the existing behavior is preserved:
06440755With:
umask 0000Oil creates:
06660777Implementation
Updated the creation modes used by:
fs.touchmkdirpIntentional private modes, such as secure temporary files and trash infrastructure using
0700, are left unchanged.No post-creation
chmodis performed.Tests
Added integration coverage for both
0002and0022umasks.Verified with:
All tests pass.