Skip to content

Update MuxedAddress handling and transfer guidelines - #143

Merged
stellar-triage-bot[bot] merged 1 commit into
stellar:mainfrom
notarobot44:patch-1
Oct 6, 2026
Merged

stellar-triage-bot[bot] merged 1 commit into
stellar:mainfrom
notarobot44:patch-1

Conversation

@notarobot44

Copy link
Copy Markdown
Contributor

Clarified handling of MuxedAddress in transfer operations and emphasized the importance of passing &Address directly to avoid compilation issues.

Clarified handling of MuxedAddress in transfer operations and emphasized the importance of passing &Address directly to avoid compilation issues.
@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Thanks for this. It is a useful pitfall to name, and it saves readers a confusing compile error.

I checked it against the soroban-sdk source for v27 (the version the skill pins) and v28:

  • The generated client types the to argument as impl Into<MuxedAddress> (fn_arg_make_into in soroban-sdk-macros).
  • MuxedAddress has both From<&Address> and From<&MuxedAddress>. So &to.into() has two valid targets and fails with E0283.
  • Passing &to works through From<&Address>. All other transfer calls in skills/ already do this.

No other file in skills/ repeats the old wording. Merging now.

@stellar-triage-bot stellar-triage-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against soroban-sdk v27 and v28 source.

@stellar-triage-bot
stellar-triage-bot Bot merged commit 1d028f1 into stellar:main Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant