Skip to content

Add CosmosPay community skill - #138

Merged
stellar-triage-bot[bot] merged 3 commits into
stellar:mainfrom
leocagli:codex/add-cosmospay-community-skill
Oct 9, 2026
Merged

stellar-triage-bot[bot] merged 3 commits into
stellar:mainfrom
leocagli:codex/add-cosmospay-community-skill

Conversation

@leocagli

Copy link
Copy Markdown
Contributor

Adds the CosmosPay skill to the Community skills directory. The skill documents SEP-7 payment intents, browser wallet approval, server-side validation, signed webhooks, and secure patterns for swaps, liquidity and fiat ramps using the public @cosmosapp/pay_sdk package. Source skill PR: CosmosPay/CosmosPay-Skill#1. Validation: pnpm lint:ts and pnpm test:ecosystem-links pass.

Copilot AI lite review requested due to automatic review settings September 22, 2026 03:49
@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

👀 Picked this up — a review will follow shortly.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed change is limited to registering the CosmosPay community skill, with no unresolved issues.

Review effort: Lite
Findings: None

What changed in this PR

Adds the CosmosPay community skill to the ecosystem directory, including Stellar payment and wallet integration documentation.

Changes:

  • Adds CosmosPay metadata and description.
  • Links to the repository’s raw SKILL.md documentation.
File Description
site/​src/​data/​skills.ts Registers the CosmosPay community skill card.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Thanks for the CosmosPay skill. Keeping the API key on the server and fulfilling only from a verified webhook or server validation is a good security boundary. I checked every call against the published @cosmosapp/pay_sdk@2.0.0 types. createPay, edit, validate, WebClient.pay, the asset constants and the Circle USDC issuers all match.

Two small fixes before the listing:

  1. references/operations.md lists managers that do not exist. In 2.0.0, Client has no assets, wallets or addresses manager. Those are exported helpers (Assets, Wallets, addresses). The real managers also include activity and pollar.
  2. references/wallets.md hand-builds a Cosmos Wallet adapter. The SDK already exports CosmosWalletAdapter and registers it by default. It covers the extension and the hosted wallet (new WebClient({ cosmos: { walletUrl } })). The hand-built copy reads globalThis.cosmosWallet once, while isAvailable() reads it live. It also does not type-check as TypeScript. Please point readers to the shipped adapter, for example with preferredWallets: [Wallets.COSMOS].

Also, please move the card to the end of ECOSYSTEM_CARDS. site/README.md asks new entries to append there.

When these are in, I will re-check and merge.

site/README.md asks new ecosystem entries to append at the end of ECOSYSTEM_CARDS.
@leocagli

leocagli commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

All three fixes are in.

  • references/operations.md: Client managers corrected — no assets/wallets/addresses managers; those are exported helpers (Assets, Wallets, addresses), and activity and pollar added as real managers. CosmosPay/CosmosPay-Skill@b3a8a9c
  • references/wallets.md: now points to the shipped CosmosWalletAdapter via preferredWallets: [Wallets.COSMOS] instead of the hand-built adapter. CosmosPay/CosmosPay-Skill@3b6a212
  • site/src/data/skills.ts: CosmosPay card moved to the end of ECOSYSTEM_CARDS per site/README.md.

Ready for re-check.

Resolve the ECOSYSTEM_CARDS conflict by keeping the CosmosPay card at the end of the list.
@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Thanks for the quick fixes. The wallets change is right: CosmosWalletAdapter, preferredWallets: [Wallets.COSMOS] and cosmos: { walletUrl } all match the SDK. The payment flow and the Circle USDC issuers still check out too.

One item is still open, and it is my fault. I checked the manager list against @cosmosapp/pay_sdk@2.0.0. Version 2.1.0 shipped on 2026-10-07, and npm install @cosmosapp/pay_sdk now installs it. In 2.1.0 the Client managers changed:

  1. pollar is gone. Client has no pollar manager in 2.1.0.
  2. assets is now a manager. client.assets is the new AssetManager (the asset registry). So "Assets ... not Client managers" is no longer true. Wallets and addresses are still helpers only.
  3. Missing managers: crossChainSwaps, aliases, plugins, defindex and publicKey are new in 2.1.0. health is also missing from the list.

Please update the list in references/operations.md to match 2.1.0. Optional: the SKILL.md description still says "a custom Cosmos Wallet adapter". The skill now points to the shipped adapter, so you may want to change that phrase.

I also merged main into your branch to fix a conflict in skills.ts. The CosmosPay card stays at the end of ECOSYSTEM_CARDS. When the list is fixed, I will re-check and merge.

@leocagli

leocagli commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

2.1.0 manager list is fixed in references/operations.md.

  • pollar removed — Client has no pollar manager in 2.1.0.
  • assets is now listed as a Client manager (the new AssetManager registry).
  • Added crossChainSwaps, aliases, plugins, defindex, publicKey and health.
  • Wallets and addresses remain exported helpers, not Client managers.

CosmosPay/CosmosPay-Skill@db22099

Ready for re-check and merge.

@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Thanks for the fast turnaround. The manager list in references/operations.md now matches @cosmosapp/pay_sdk@2.1.0, which is still npm latest. I checked it against the Client class in the 2.1.0 types:

  • All 18 managers are covered, including assets, crossChainSwaps, aliases, plugins, defindex, publicKey and health.
  • pollar is gone.
  • Wallets, addresses, Assets and TestnetAssets are still exported helpers.

The card is a clean append at the end of ECOSYSTEM_CARDS, and both card URLs resolve. Optional, not blocking: the SKILL.md description still says "a custom Cosmos Wallet adapter".

Approving and merging now.

@stellar-triage-bot stellar-triage-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: clean ECOSYSTEM_CARDS append; skill content matches @cosmosapp/pay_sdk 2.1.0.

@stellar-triage-bot
stellar-triage-bot Bot merged commit ac6c9f0 into stellar:main Oct 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants