[codex] Recover browser image artifact downloads#252
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 12, 2026, 12:15 AM ET / 04:15 UTC. Summary Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against b1c0755507ed. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Maintainer update: I could not push the verified fixup commit to this fork branch; GitHub rejected I preserved this PR's contributor commits and pushed the repaired stack to Keeping this PR open per maintainer instruction. |
Summary
Root Cause
Long-running manual-login browser image runs could fail in two adjacent ways. Fresh manual-login Chrome launches still used zero retries when opening an isolated DevTools tab, so a transient
ECONNREFUSEDsurfaced immediately. Separately, generated image URLs could be visible in the ChatGPT page but fail from Node-side fetch; fetching inside the authenticated browser context recovers those artifacts.Validation
pnpm exec vitest run tests/browser/chromeLifecycle.test.ts tests/browser/chatgptImages.test.tspnpm run buildpnpm run format:checkpnpm run lintfetch failedand saved a valid PNG