Symlink CLAUDE.md to AGENTS.md - #2640
Conversation
|
Codex review: needs changes before merge. Reviewed August 9, 2026, 7:12 PM ET / 23:12 UTC. ClawSweeper reviewWhat this changesThis PR adds CLAUDE.md as a symlink to the shared AGENTS.md guidance and removes a stray trailing marker from that guidance. Merge readinessKeep open: the symlink’s Claude Code behavior is demonstrated, but the new root instruction entry point is not covered by the CI path gate that protects contributor contracts. Priority: P3 Review scores
Verification
How this fits togetherRoot guidance files tell coding assistants how to work in CodexBar. The CI path gate classifies changed files to decide whether macOS Swift tests must run before the workflow continues. flowchart LR
A[Changed pull-request paths] --> B[CI path gate]
B --> C{Contributor contract?}
C -->|AGENTS.md| D[Require macOS Swift tests]
C -->|CLAUDE.md today| E[Skip as Markdown]
D --> F[macOS test shards]
E --> G[Portable checks only]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Treat both root guidance aliases as contributor contracts in the path gate and cover modify plus both rename directions in its regression matrix. Do we have a high-confidence way to reproduce the issue? Yes—source inspection gives a high-confidence path: a CLAUDE.md-only modification or rename reaches the generic Markdown branch and skips the macOS-test requirement. Is this the best way to solve the issue? No—the symlink is the maintainable shared-guidance mechanism, but it should ship with matching CI classification and regression coverage for the new alias. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a0d77c37f9cc. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (21 earlier review cycles; latest 8 shown)
|
|
Note for reviewers: the failing Evidence that it is environmental:
Root cause and fix: #2644. I cannot rerun the job, since that needs admin rights on this repository. Once |
|
I think a rebase after #2644 lands will result in less flakes. |
250ffaa to
e1c9bf1
Compare
|
Rebased post #2644 merge. |
e1c9bf1 to
ed3e340
Compare
ed3e340 to
37a3bd3
Compare
37a3bd3 to
c075e19
Compare
|
@steipete easy PR win here for ya. |
Summary
CLAUDE.md -> AGENTS.mdas a symlink so Claude Code picks up the same repository guidelines already documented for agents.***spotted inAGENTS.md.Test plan
claudesession./contextand confirm we seeCLAUDE.mdin context.CLAUDE.md: 2.4k tokens.