Add native Polish localization support#1253
Conversation
|
Codex review: found issues before merge. Reviewed June 1, 2026, 4:49 AM ET / 08:49 UTC. Summary Reproducibility: yes. for this PR: comparing the PR-head Polish and English string tables shows 815 of 1029 Polish values still match English, and the supplied screenshots show mixed Polish/English UI after selecting Polish. I did not run the macOS app locally. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Ship Polish only after the Do we have a high-confidence way to reproduce the issue? Yes for this PR: comparing the PR-head Polish and English string tables shows 815 of 1029 Polish values still match English, and the supplied screenshots show mixed Polish/English UI after selecting Polish. I did not run the macOS app locally. Is this the best way to solve the issue? No: enabling Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 4756ba06bf42. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 545c87d4ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /* English localization for CodexBar (base/fallback) */ | ||
|
|
||
| " providers" = " providers"; | ||
| "(System)" = "(System)"; | ||
| "30d" = "30d"; | ||
| "A managed Codex login is already running. Wait for it to finish before adding " = "A managed Codex login is already running. Wait for it to finish before adding "; |
There was a problem hiding this comment.
Translate the Polish strings before enabling Polish
When users select the new Polish language, localizedBundle() will load this pl.lproj file, but the file is still mostly the English/base table (864 of 1029 entries match English, starting with the provider/login/account strings here). That makes the newly advertised Polish option render large parts of the app in English rather than Polish; translate these entries before shipping the language option.
Useful? React with 👍 / 👎.
|
@clawsweeper re-review Addressed in latest commits ( Proof (Polish selected in app)1) Menu popup (core usage card + actions)
2) General settings pane
3) Providers pane
4) Display settings pane
5) Advanced settings pane
Notes
|
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|





Summary
pl) as a selectable app languagepl.lproj/Localizable.stringsfor native Polish localizationlanguage_polishlabel across existing localesTesting
swift testtargets