Modernize MiniMax Token Plan and M3 usage display#1249
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 1, 2026, 9:28 AM ET / 13:28 UTC. Summary Reproducibility: yes. for source-level review: the reset-time regression is visible from the PR head source by comparing its Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land one canonical MiniMax Token Plan update that preserves both legacy seconds and current millisecond reset values, documents product behavior cleanly, treats MiniMax snapshot persistence as an intentional choice, and includes redacted real behavior proof. Do we have a high-confidence way to reproduce the issue? Yes for source-level review: the reset-time regression is visible from the PR head source by comparing its Is this the best way to solve the issue? No, not as-is: the MiniMax Token Plan direction is plausible, but the patch should first preserve reset-time compatibility, remove PR-specific docs wording, attach real behavior proof, and reconcile the overlapping landing path. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 4756ba06bf42. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
5fcb49f to
12c4b4a
Compare
|
Proof update:\n\n- passed (, ).\n- PR scope diff is limited to MiniMax UI/fetcher/snapshot/tests + + .\n- Redacted screenshots are required and should include:\n 1. Preferences > Providers > MiniMax\n 2. MiniMax console Token Plan 5h/weekly/credits views\n\nSecurity reminder: no real keys, cookies, auth headers, group/account IDs, purchase/order IDs, or HAR dumps in uploads. |
|
Proof update:
Security reminder: do not upload real keys, cookies, authorization headers, group/account IDs, purchase/order IDs, or full HAR dumps. |
3e7529d to
b3b1071
Compare
b3b1071 to
3409703
Compare
3409703 to
e937037
Compare
|
I’m closing this PR for now instead of continuing to expand it. While investigating MiniMax’s current Token Plan / M3 console behavior, I found we need a clearer integration/design split before this is merge-ready. Redacted findings
Remains semantics observed
Credits and subscription metadata
Runtime split observed locally
Why close nowI don’t want to merge a half-proven MiniMax behavior change that may confuse users or future maintainers. A cleaner follow-up likely needs to explicitly decide between:
Closing this PR avoids further churn while preserving investigation notes for a more complete follow-up implementation. |
Summary
Modernize MiniMax-only usage presentation and parsing for current Token Plan / M3 surfaces while preserving existing auth paths.
What Changed
remainssemantics.model_name == "general"as the primary text/coding quota source (video stays secondary and does not override primary quota).100 - current_interval_remaining_percent100 - current_weekly_remaining_percentremains_timeandweekly_remains_time.token_plan_credit(total/used/remaining) while explicitly ignoringapi_key.cycle_resource_package(title, tier, expiry/end time, credit total when provided).MINIMAX_CODING_API_KEY)Scope
docs/minimax.mddocs/providers.mdNo changes to unrelated providers.
Validation
swift test --filter MiniMax73 testsacross13 suites).Proof
Security / Redaction
This PR and test fixtures do not include real secrets or personal identifiers. Specifically excluded/redacted:
sk-cpkeys