Avoid auto-launching blocked Codex CLI candidates#1038
Draft
m-rokai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex.jsshims and assess their vendored native Codex binary without launching itWhy
A local repro machine kept seeing macOS "malware" warnings even though
CodexBar.appitself was notarized and accepted by Gatekeeper. The suspicious launch target was the Codex CLI candidate selected from PATH:The same machine also had a signed Codex.app CLI available:
Before this change, CodexBar would pick the PATH shim first and could keep touching the blocked native binary through background/version probes. This change makes Codex resolution treat blocked candidates as unavailable for automatic selection, while preserving
CODEX_CLI_PATHas an explicit user override.Validation
swift test --filter PathBuilderTestsswift test --filter CodexCLILaunchGateTestsgit diff --checkNot run:
swiftformat/swiftlintbecause they are not installed in this local environment.