Conversation
Replaces relative tolerance assertions with ULP difference assertions via `@stdlib/number/float32/base/assert/is-almost-same-value`. The measured ULP difference is `1` for both the JavaScript and C implementations, so assertions use a bound of `1` ULP. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KxF75yiDdfVHBFJAQ4kd5R --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/strided/sstdevtkfrom relative tolerance assertions to ULP-based assertions, replacing thedelta/tolcomputation (delta = abs( v - expected ),tol = 1.0 * EPS * abs( expected )) withisAlmostSameValuef( v, expected, 1 )via@stdlib/number/float32/base/assert/is-almost-same-value.@stdlib/math/base/special/absand@stdlib/constants/float32/epsrequires.'returns expected value'.Files changed (test files only):
test/test.sstdevtk.jstest/test.sstdevtk.native.jstest/test.ndarray.jstest/test.ndarray.native.jsFinal ULP constant:
1(used in all four test files).This was tightened from an initial bound of
64. The measured ULP difference for the single affected assertion is exactly1for both the JavaScript and C implementations:A bound of
0ULP fails, confirming1is the minimum.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
1ULP to confirm determinism; the native add-on was built locally (node-gyp rebuild) so thattest.*.native.jsassertions were actually exercised rather than skipped. All five test files pass (77 assertions, 0 failures) on both runs.etc/eslint/.eslintrc.tests.js).editorconfig-checkerstep could not run in this environment because its binary is downloaded from a GitHub release that outbound network policy blocked. EditorConfig compliance was instead verified manually for the changed files: LF line endings, UTF-8 (ASCII), tab indentation, no trailing whitespace, and a final newline.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, following the idiom established by previously merged conversions in the same family (e.g.
stats/strided/sstdevpn). The ULP bound was measured empirically rather than guessed.@stdlib-js/reviewers
Generated by Claude Code