Repository navigation
test: migrate stats/incr/gmean to ULP-based assertions - #15759
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P8miTQQZYJqEoGvMgwvgKY
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
October 2, 2026 02:03
kgryte
reviewed
Oct 2, 2026
kgryte
reviewed
Oct 2, 2026
kgryte
reviewed
Oct 2, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #{{TODO: add issue number}}.
Description
This pull request:
@stdlib/stats/incr/gmeanfrom EPS-based tolerance comparisons to ULP-based assertions using@stdlib/assert/is-almost-same-value.ULP = 2, intest/test.js. The minimum ULP difference that passes over the full test set was measured as 2 (starting from 64; 1 and 0 fail), and the suite was run twice at 2 with identical results.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only
test/test.jsis changed. The local pre-commit EditorConfig hook could not download its binary in the sandbox (403), so the commit was made with--no-verify;eslintwas run manually and is clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01P8miTQQZYJqEoGvMgwvgKY
Generated by Claude Code