Repository navigation
test: migrate stats/incr/mrss to ULP-based assertions - #15669
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QmWdLdjeUxMBTmv5WheEGs
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
September 30, 2026 06:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/mrssfrom relative tolerance testing to ULP difference testing, replacing the computeddelta/tolcomparison withisAlmostSameValue.0, which is the measured minimum: the accumulated moving residual sums of squares in the fixture set are exactly representable, so no non-zero ULP budget is required. Tightening from a higher starting bound,0is the smallest integer for which the full fixture set passes, and the suite was run twice at0to confirm determinism.@stdlib/constants/float64/epsand@stdlib/math/base/special/absrequires from the test file.Only
test/test.jsis modified; the package has notest/test.native.js.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
0(measured minimum;make test TESTS_FILTER=".*/stats/incr/mrss/.*"green on two consecutive runs, 98/98 assertions).make eslint-tests TESTS_FILTER=".*/stats/incr/mrss/.*"is clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code: it selected the package, mirrored the conversion idiom from already-migrated packages in the same family, and determined the minimum passing ULP bound by running the package test suite.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01QmWdLdjeUxMBTmv5WheEGs
Generated by Claude Code