Skip to content

feat: add C implementation for stats/base/dists/f/quantile - #15410

Merged
Planeshifter merged 7 commits into
philipp/betaprime-quantile-cfrom
philipp/f-quantile-c
Oct 5, 2026
Merged

feat: add C implementation for stats/base/dists/f/quantile#15410
Planeshifter merged 7 commits into
philipp/betaprime-quantile-cfrom
philipp/f-quantile-c

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Progresses stdlib-js/metr-issue-tracker#1236.

Description

What is the purpose of this pull request?

This pull request:

  • adds a C implementation for @stdlib/stats/base/dists/f/quantile

The implementation uses kernel-betaincinv directly, preserving both the inverse value and its complement via out-pointers to maintain numerical accuracy in extreme tails (avoids recomputing the complement via subtraction).

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code under my direction.

@stdlib-js/reviewers

@Planeshifter Planeshifter mentioned this pull request Sep 21, 2026
Merged
5 of 7 tasks
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Sep 21, 2026
@stdlib-bot

stdlib-bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/f/quantile $\\color{green}311/311$
$\\color{green}+0.97\\%$ 		$\\color{green}24/24$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+33.33\\%$ 		$\\color{green}311/311$
$\\color{green}+0.97\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-js stdlib-js deleted a comment from stdlib-bot Sep 21, 2026
@stdlib-js stdlib-js deleted a comment from stdlib-bot Sep 21, 2026
@Planeshifter
Planeshifter force-pushed the philipp/f-quantile-c branch 2 times, most recently from e262ad3 to 2e5b372 Compare September 21, 2026 20:38
@Planeshifter
Planeshifter marked this pull request as ready for review September 21, 2026 20:44
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 21, 2026
@Planeshifter Planeshifter added the METR Pull request associated with the METR project. label Sep 22, 2026
@anandkaranubc anandkaranubc mentioned this pull request Oct 2, 2026
Open
@anandkaranubc
anandkaranubc force-pushed the philipp/betaprime-quantile-c branch from 50d553a to 8b9c85a Compare October 3, 2026 23:43
@anandkaranubc
anandkaranubc self-requested a review October 4, 2026 19:23
@Planeshifter @claude @anandkaranubc
feat: add C implementation for stats/base/dists/f/quantile
adf3b64 
This commit adds a complete C/native surface for the F distribution
quantile function. The implementation uses kernel-betaincinv directly,
preserving both the inverse value and its complement via out-pointers
to maintain numerical accuracy in extreme tails.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@anandkaranubc
test: use ULP-based assertions
3a19b6f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
style: fix variable declaration order
1d9aede 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: code review
10ac172 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
fix: add missing Makefile for C source
23f3f7f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
bench: add missing native benchmark
1f20fff 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: remove unused fixtures
cef06c4 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc added C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. labels Oct 4, 2026
anandkaranubc
anandkaranubc approved these changes Oct 4, 2026
View reviewed changes

@anandkaranubc anandkaranubc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, @Planeshifter

@Planeshifter
Planeshifter merged commit 4b21348 into philipp/betaprime-quantile-c Oct 5, 2026
47 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 5, 2026
Planeshifter added a commit that referenced this pull request Oct 5, 2026
@Planeshifter @anandkaranubc
feat: add C implementation for stats/base/dists/f/quantile
1063e49 
PR-URL: #15410
Ref: stdlib-js/metr-issue-tracker#1236

Co-authored-by: Karan Anand <anandkarancompsci@gmail.com>
Reviewed-by: Karan Anand <anandkarancompsci@gmail.com>
Planeshifter added a commit that referenced this pull request Oct 5, 2026
@Planeshifter @anandkaranubc
feat: add C implementations for beta prime and F distribution quantile
93262c2 
PR-URL: #15388
PR-URL: #15410
Ref: stdlib-js/metr-issue-tracker#1235

Co-authored-by: Karan Anand <anandkarancompsci@gmail.com>
Reviewed-by: Karan Anand <anandkarancompsci@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandkaranubc anandkaranubc anandkaranubc approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Planeshifter @stdlib-bot @anandkaranubc