Skip to content

starknet_committer_and_os_cli: create_execution_resources with opcodes#13222

Merged
avivg-starkware merged 1 commit intomain-v0.14.2from
avivg/starknet_commiter_and_os_cli/create_er_with_opcodes
Mar 18, 2026
Merged

starknet_committer_and_os_cli: create_execution_resources with opcodes#13222
avivg-starkware merged 1 commit intomain-v0.14.2from
avivg/starknet_commiter_and_os_cli/create_er_with_opcodes

Conversation

@avivg-starkware
Copy link
Copy Markdown
Contributor

@avivg-starkware avivg-starkware commented Mar 12, 2026

Note

Low Risk
Low risk: changes are confined to test fixtures, adding explicit opcode instance counters; main risk is minor test expectation/serialization differences if consumers assume default/empty opcode maps.

Overview
Test helpers in block_hash_cli/tests/objects.rs now build ExtendedExecutionResources with an explicit opcode_instance_counter (adding OpcodeName::blake with a provided count) instead of relying on defaults.

All fixture construction sites (CallInfo and TransactionResources) were updated to pass the new blake_opcode_count parameter when creating execution resources.

Written by Cursor Bugbot for commit 3dfb89f. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@avivg-starkware avivg-starkware marked this pull request as ready for review March 12, 2026 10:17
Copy link
Copy Markdown
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@meship-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noaov1).

@avivg-starkware avivg-starkware changed the title starknet_commiter_and_os_cli: create_execution_resources with opcodes starknet_committer_and_os_cli: create_execution_resources with opcodes Mar 18, 2026
@avivg-starkware avivg-starkware added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main-v0.14.2 with commit 6ba9459 Mar 18, 2026
35 of 41 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants