Skip to content

Fix view transition check #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bencroker merged 2 commits into from
Aug 21, 2026
Merged

Fix view transition check #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01337b0
Fix view transition check
bencroker Jul 8, 2026
56b9543
Merge branch 'develop' into fix-view-transition-check
bencroker Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions bundles/datastar.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions bundles/datastar.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions library/src/globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
declare const ALIAS: string | null

interface Element {
startViewTransition(callback: () => void | Promise<void>): ViewTransition
}
14 changes: 9 additions & 5 deletions library/src/plugins/watchers/patchElements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,19 @@ watcher({
elements,
}

if (useViewTransition && supportsViewTransitions()) {
let element: any = document.documentElement
if (useViewTransition) {
let target: Document | Element = document
if (viewTransitionSelector) {
const el = document.querySelector(viewTransitionSelector)
if (el && supportsViewTransitions(el)) {
element = el
if (el) {
target = el
}
}
element.startViewTransition(() => onPatchElements(ctx, patchElementsArgs))
if (supportsViewTransitions(target)) {
target.startViewTransition(() => onPatchElements(ctx, patchElementsArgs))
} else {
onPatchElements(ctx, patchElementsArgs)
}
} else {
onPatchElements(ctx, patchElementsArgs)
}
Expand Down
7 changes: 3 additions & 4 deletions library/src/utils/view-transitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import type { EventCallbackHandler, Modifiers } from '@engine/types'

export const supportsViewTransitions = (
element: Element = document.documentElement,
): boolean => 'startViewTransition' in element
export const supportsViewTransitions = (target: Document | Element): boolean =>
'startViewTransition' in target

export const modifyViewTransition = (
callback: EventCallbackHandler,
mods: Modifiers,
): EventCallbackHandler => {
if (mods.has('viewtransition') && supportsViewTransitions()) {
if (mods.has('viewtransition') && supportsViewTransitions(document)) {
const cb = callback // I hate javascript
callback = (...args: any[]) =>
document.startViewTransition(() => cb(...args))
Expand Down