fix validation fraction api - #407
Merged
Merged
Conversation
Collaborator
Author
|
@alejandroschuler can you review this as well? I can update the release here after #411 merges and include the there PR you merged |
alejandroschuler
approved these changes
Jun 23, 2026
alejandroschuler
left a comment
alejandroschuler
left a comment
Collaborator
There was a problem hiding this comment.
should we also update NGBSurvival?
…tion # Conflicts: # tests/test_basic.py
Collaborator
Author
Yes, I'll push an update |
alejandroschuler
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented issue to close #402 by fixing API parity for validation-based early stopping in classification.
What changed
Added validation_fraction and early_stopping_rounds to
NGBClassifier.__init__and forwarded both to NGBoost.Added regression test
test_classifier_validation_fraction_is_supportedto ensure classifier accepts these params, exposes them viaget_params(), and trains/predicts with validation-split early stopping enabled.