Minor fixes#87
Merged
Merged
Conversation
Member
|
Hi, the lifetimes fixes are fine but I am not ready to review #68 as it might break some tests upstream. |
A missing lifetime in the GetHeader trait was inferred by lifetime elision rules to be shorter than necessary, leading to awkward lifetime constraints being propagated throughout many functions that didnt need them.
Contributor
Author
|
I'm aware and think it is good not to merge #68 as-is without in-depth testing. All other commits have been structured so their correctness is as obvious as can be from looking at the diff. I've pushed some formatting tweaks to make the diffs even smaller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the commits in PR #68 I think are valuable on their own, I've extracted them into this PR, and added intermediate steps to justify the changes. As I was doing this, I saw some other issues, and added fixes for that as well.