Restore original agent working-spinner size in AgentStateDot#8172
Merged
Conversation
PR #7423 resized the working spinner ring from the dot size to the icon size (sm: 6px -> 10px, md: 8px -> 12px) as a side effect of the AI Vault subagent display work. The size change was unintentional in the sidebar agent rows, so restore the original dot sizing.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe working-state spinner in 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #7423 (AI Vault subagent display) resized the
AgentStateDotworking-spinner ring from the dot size (inner) to the icon size (icon) — sm: 6px → 10px, md: 8px → 12px. That size bump was unintentional for the sidebar agent status rows, where the spinner now reads noticeably oversized next to the worktree-levelStatusIndicatorspinner.This restores the original
innersizing for the working state and drops the comment that justified the icon sizing.Testing
npx vitest run --config config/vitest.config.ts src/renderer/src/components/AgentStateDot.test.ts src/renderer/src/components/sidebar/StatusIndicator.test.ts— 10/10 pass