Skip to content

Restore original agent working-spinner size in AgentStateDot#8172

Merged
brennanb2025 merged 1 commit into
mainfrom
brennanb2025/agent-spinner-size-revert
Jul 10, 2026
Merged

Restore original agent working-spinner size in AgentStateDot#8172
brennanb2025 merged 1 commit into
mainfrom
brennanb2025/agent-spinner-size-revert

Conversation

@brennanb2025

Copy link
Copy Markdown
Contributor

Summary

PR #7423 (AI Vault subagent display) resized the AgentStateDot working-spinner ring from the dot size (inner) to the icon size (icon) — sm: 6px → 10px, md: 8px → 12px. That size bump was unintentional for the sidebar agent status rows, where the spinner now reads noticeably oversized next to the worktree-level StatusIndicator spinner.

This restores the original inner sizing for the working state and drops the comment that justified the icon sizing.

Testing

  • npx vitest run --config config/vitest.config.ts src/renderer/src/components/AgentStateDot.test.ts src/renderer/src/components/sidebar/StatusIndicator.test.ts — 10/10 pass

PR #7423 resized the working spinner ring from the dot size to the
icon size (sm: 6px -> 10px, md: 8px -> 12px) as a side effect of the
AI Vault subagent display work. The size change was unintentional in
the sidebar agent rows, so restore the original dot sizing.
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c72d1307-0933-40df-a93e-e4a645dfe948

📥 Commits

Reviewing files that changed from the base of the PR and between b93a7ee and 025edf7.

📒 Files selected for processing (1)
  • src/renderer/src/components/AgentStateDot.tsx

📝 Walkthrough

Walkthrough

The working-state spinner in AgentStateDot now applies the inner size value directly in its class composition while retaining the transparent top-border styling.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes summary and testing, but it omits required Screenshots, AI Review Report, Security Audit, and Notes sections. Add the missing template sections, especially screenshots, AI review report, security audit, and notes, or explicitly mark them as not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: restoring the AgentStateDot working-spinner size.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brennanb2025
brennanb2025 merged commit fe71421 into main Jul 10, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant