Fix GitLab auth diagnostic waking WSL#7967
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds an 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Clean auto-merge, no conflicts (109 files, +7490 from main). Brought in: - Codex WSL runtime status hooks (#7969); WSL/SSH agent path resolution past shell aliases (#7867); WSL source-control path separators (#7966); WSL GitLab-auth wake fix (#7967); WSL Codex usage RPC refresh (#7567/#7658) - Improve workspace cleanup list (#7053) + background removal - mobile: per-host connection log + Tailscale wedge recovery (#7984/#7980), wake slept agents on mobile worktree open (#7906) - Harden layout validation, watcher lifecycle, connection robustness (#7924) - Disable experimental worktree card style by default (#7977) Perf-branch structure preserved (clean auto-merge). typecheck 0 errors; lint 0 errors. CI is the release gate (local runs skipped per env lag). Co-authored-by: Orca <help@stably.ai>
Summary
Root cause and reproduction
On Windows, diagnoseAuth() runs cwd-less glab auth status. When host glab returns ENOENT, the shared runner automatically resolves the default WSL distro and retries through wsl.exe, even when the workspace and agent runtimes are Windows and GitLab is unused.
The regression harness simulates that exact subprocess sequence: Windows host glab missing, Ubuntu configured as the default distro, and the global auth command invoked. Before the fix it recorded a second wsl.exe call running glab auth status. It now asserts that the host-only diagnostic stops after the single host attempt. A separate existing test continues to cover default-WSL fallback for ordinary cwd-less GitLab API operations.
Validation
Closes #7536