Skip to content

Delete the hidden renderer skip grammar#5170

Closed
nwparker wants to merge 14 commits into
nwparker/term-speed-2-query-authority-alignmentfrom
nwparker/term-speed-2-skip-grammar-removal
Closed

Delete the hidden renderer skip grammar#5170
nwparker wants to merge 14 commits into
nwparker/term-speed-2-query-authority-alignmentfrom
nwparker/term-speed-2-skip-grammar-removal

Conversation

@nwparker

@nwparker nwparker commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Phase 6 — the deletion the architecture earned. Net −1,284 lines.

With the model owning hidden content (delivery gate), side effects (facts channel), and queries (model responder), the renderer's per-chunk hidden classification has no remaining purpose:

  • hidden-renderer-skip-eligibility.ts and its tests deleted; every skip/scan path in pty-connection.ts removed (the eligibility grammar, DEC-2026 hidden classification state, split-boundary scans, mode-2031 byte scanning, skip-latch semantics)
  • the 10s codex startup query window deleted; codex spawns are now hidden-marked from byte zero and the model responder answers their startup probes (end-to-end pinned)
  • the hidden data path is now three lines of policy: foreground → write; restore latched → reconcile; otherwise → background queue (2 MB lossy cap → restore marker → snapshot restore) — which is also the complete kill-switch-off fallback, pinned by a new test
  • hidden-output-restore machinery fully retained (it is the reveal reconciliation for the gate and the overflow path)
  • kept deliberately: the parked 2031 byte sidecar (sole answerer for switch-off parked tabs — per-mode audit documented in its header)

E2E contract updates

Pressure scenarios retitled from "skips renderer writes" to "withholds renderer delivery"; structurally-zero skip-counter assertions removed (main's hiddenDeliveryDroppedChars is the load-bearing withheld-output signal); the rich-model 11s delay deleted (existed only for the startup window); long-table and visual-restore specs trimmed of dead debug fields.

Validation

  • typecheck clean; oxlint clean
  • 2,377 unit tests green (74-file renderer sweep + 83-file main sweep); 14 grammar tests deleted, 5 reworked to overflow-driven restore, new fallback-chain and codex-spawn pins added
  • e2e: 17 visual/parking/memory/attention/sleep-wake + 6 pressure + golden 2/2 on fresh builds

Cut-off

Independently mergeable; completes Phases 5–6. Phase 7 (final benchmark matrix + over-time report) follows.

Made with Orca 🐋

nwparker and others added 2 commits June 11, 2026 00:08
Co-authored-by: Orca <help@stably.ai>
…wparker/term-speed-2-skip-grammar-removal

# Conflicts:
#	src/renderer/src/components/terminal-pane/hidden-renderer-skip-eligibility.test.ts
#	src/renderer/src/components/terminal-pane/hidden-renderer-skip-eligibility.ts
#	src/renderer/src/components/terminal-pane/pty-connection.test.ts
#	src/renderer/src/components/terminal-pane/pty-connection.ts
@stage-review

stage-review Bot commented Jun 16, 2026

Copy link
Copy Markdown

nwparker added 12 commits June 16, 2026 16:32
…wparker/term-speed-2-skip-grammar-removal

# Conflicts:
#	tests/e2e/terminal-long-table-scroll-restore.spec.ts
…wparker/term-speed-2-skip-grammar-removal

# Conflicts:
#	src/renderer/src/components/terminal-pane/pty-connection.ts
…wparker/term-speed-2-skip-grammar-removal

# Conflicts:
#	src/renderer/src/components/terminal-pane/pty-connection.test.ts
…wparker/term-speed-2-skip-grammar-removal

# Conflicts:
#	src/renderer/src/components/terminal-pane/pty-connection.test.ts
…wparker/term-speed-2-skip-grammar-removal

# Conflicts:
#	src/renderer/src/components/terminal-pane/pty-connection.ts
…wparker/term-speed-2-skip-grammar-removal

# Conflicts:
#	src/renderer/src/components/terminal-pane/pty-connection.ts
…wparker/term-speed-2-skip-grammar-removal

# Conflicts:
#	src/renderer/src/components/terminal-pane/pty-connection.ts
@nwparker

Copy link
Copy Markdown
Contributor Author

Closing as superseded by merged PR #7214 (merge e84a8dd), which explicitly revived the complete term-speed-2 model/view chain into current main and then added newer scheduler, producer flow-control, snapshot, and reliability work. This old component/rollup branch no longer has an independent delta to rebase.

@nwparker nwparker closed this Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant