Delete the hidden renderer skip grammar#5170
Closed
nwparker wants to merge 14 commits into
Closed
Conversation
Co-authored-by: Orca <help@stably.ai>
…wparker/term-speed-2-skip-grammar-removal # Conflicts: # src/renderer/src/components/terminal-pane/hidden-renderer-skip-eligibility.test.ts # src/renderer/src/components/terminal-pane/hidden-renderer-skip-eligibility.ts # src/renderer/src/components/terminal-pane/pty-connection.test.ts # src/renderer/src/components/terminal-pane/pty-connection.ts
|
Ready to review this PR? Stage has broken it down into 7 individual chapters for you: Chapters generated by Stage for commit 4f2ee31 on Jun 17, 2026 10:14am UTC. |
…wparker/term-speed-2-skip-grammar-removal # Conflicts: # tests/e2e/terminal-long-table-scroll-restore.spec.ts
…wparker/term-speed-2-skip-grammar-removal # Conflicts: # src/renderer/src/components/terminal-pane/pty-connection.ts
…wparker/term-speed-2-skip-grammar-removal # Conflicts: # src/renderer/src/components/terminal-pane/pty-connection.test.ts
…wparker/term-speed-2-skip-grammar-removal # Conflicts: # src/renderer/src/components/terminal-pane/pty-connection.test.ts
…wparker/term-speed-2-skip-grammar-removal
…wparker/term-speed-2-skip-grammar-removal # Conflicts: # src/renderer/src/components/terminal-pane/pty-connection.ts
…wparker/term-speed-2-skip-grammar-removal
…wparker/term-speed-2-skip-grammar-removal # Conflicts: # src/renderer/src/components/terminal-pane/pty-connection.ts
…wparker/term-speed-2-skip-grammar-removal
…wparker/term-speed-2-skip-grammar-removal # Conflicts: # src/renderer/src/components/terminal-pane/pty-connection.ts
…wparker/term-speed-2-skip-grammar-removal
…wparker/term-speed-2-skip-grammar-removal
Contributor
Author
|
Closing as superseded by merged PR #7214 (merge e84a8dd), which explicitly revived the complete term-speed-2 model/view chain into current main and then added newer scheduler, producer flow-control, snapshot, and reliability work. This old component/rollup branch no longer has an independent delta to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 6 — the deletion the architecture earned. Net −1,284 lines.
With the model owning hidden content (delivery gate), side effects (facts channel), and queries (model responder), the renderer's per-chunk hidden classification has no remaining purpose:
hidden-renderer-skip-eligibility.tsand its tests deleted; every skip/scan path inpty-connection.tsremoved (the eligibility grammar, DEC-2026 hidden classification state, split-boundary scans, mode-2031 byte scanning, skip-latch semantics)E2E contract updates
Pressure scenarios retitled from "skips renderer writes" to "withholds renderer delivery"; structurally-zero skip-counter assertions removed (main's
hiddenDeliveryDroppedCharsis the load-bearing withheld-output signal); the rich-model 11s delay deleted (existed only for the startup window); long-table and visual-restore specs trimmed of dead debug fields.Validation
Cut-off
Independently mergeable; completes Phases 5–6. Phase 7 (final benchmark matrix + over-time report) follows.
Made with Orca 🐋