Gate PTY delivery to hidden terminal views#5135
Closed
nwparker wants to merge 11 commits into
Closed
Conversation
Co-authored-by: Orca <help@stably.ai>
…r/term-speed-2-hidden-delivery-gate # Conflicts: # src/preload/api-types.ts # src/preload/index.ts # src/renderer/src/components/terminal-pane/pty-connection.ts
|
Ready to review this PR? Stage has broken it down into 16 individual chapters for you: Chapters generated by Stage for commit f70350b on Jun 17, 2026 9:35am UTC. |
…r/term-speed-2-hidden-delivery-gate
…r/term-speed-2-hidden-delivery-gate
…r/term-speed-2-hidden-delivery-gate
…r/term-speed-2-hidden-delivery-gate
…r/term-speed-2-hidden-delivery-gate
…r/term-speed-2-hidden-delivery-gate
…r/term-speed-2-hidden-delivery-gate
Contributor
Author
|
Closing as superseded by merged PR #7214 (merge e84a8dd), which explicitly revived the complete term-speed-2 model/view chain into current main and then added newer scheduler, producer flow-control, snapshot, and reliability work. This old component/rollup branch no longer has an independent delta to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 of the terminal model/view architecture: main stops sending PTY bytes to hidden terminal views entirely.
hiddenRendererPtysgate inpty.ts: bytes for hidden views are dropped after model ingestion (never queued) — the headless model owns them and reveal reconciles via snapshot+seq; SSH relay parity inwireUpPtyEventssubscribeToPtyDataregistrations; the codex 10s startup query window stays exemptisHiddenDeliveryGateManagedPty: fact is the sole responder for gated panes)pty:modelRestoreNeededIPC replaces any in-band signaling (an OSC-9999-only chunk can strip to empty — it must never masquerade as a restore marker)pendingDeliveryStartSeqwith each snapshot so the renderer arms a duplicate-suppression baseline only for a real undelivered window; seq-continuity gap detection forces a fresh snapshot when the pending-cap trims behind a completed restorependingDatagrowth under ACK starvation is capped (2 MB oldest-drop + restore marker), gated on the same kill switches; switches-off is byte-identical to todayterminalMainSideEffectAuthorityAND newterminalHiddenDeliveryGate(default on), read main-sideReview hardening (3-lens adversarial review + deterministic e2e regression fix, all red-verified)
Validation
mainHiddenDroppedCharscarries the evidence, renderer queues ~0); golden 2/2mainHiddenGatedPtys/mainHiddenDroppedChars/mainPendingDroppedCharsfor the over-time reportCut-off
Independently mergeable; completes the Phase 3–4 arc. Phase 5 (model query authority for hidden panes, design committed next) is the final behavioral phase before the skip-grammar deletion.
Made with Orca 🐋