Finish terminal side-effect authority migration#5123
Closed
nwparker wants to merge 9 commits into
Closed
Conversation
Co-authored-by: Orca <help@stably.ai>
…nwparker/term-speed-2-side-effect-cleanup # Conflicts: # src/main/runtime/orca-runtime.ts
|
Ready to review this PR? Stage has broken it down into 9 individual chapters for you: Chapters generated by Stage for commit a23fedf on Jun 17, 2026 9:34am UTC. |
…nwparker/term-speed-2-side-effect-cleanup
…nwparker/term-speed-2-side-effect-cleanup
…nwparker/term-speed-2-side-effect-cleanup
…nwparker/term-speed-2-side-effect-cleanup
…nwparker/term-speed-2-side-effect-cleanup
…nwparker/term-speed-2-side-effect-cleanup
…nwparker/term-speed-2-side-effect-cleanup
Contributor
Author
|
Closing as superseded by merged PR #7214 (merge e84a8dd), which explicitly revived the complete term-speed-2 model/view chain into current main and then added newer scheduler, producer flow-control, snapshot, and reliability work. This old component/rollup branch no longer has an independent delta to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 slice 4 — completes the side-effect authority migration (design:
docs/reference/terminal-side-effect-authority.md).command-code-working/command-code-donefacts (banner self-arming preserved, plusruntime.noteTerminalSpawnCommandfor the startup fast-arm since agent kind isn't known main-side). The 1500ms done settle timer deliberately stays in the renderer policy layer — it must consult the live store row that hook events also write (contract invariant 3)setAgentStatusfor PTYs main covers; their pacing/automation responsibilities and byte access are untouchedparked-terminal-mode2031-responder.tswhose byte subscription doubles as the Phase 4 delivery-interest signallastTitletraced as write-only today and documented in the doc's Open ItemsParity improvement (pinned by test)
The old renderer raw-byte path's ANSI strip leaked OSC-9999 payload text into Command Code prompt-echo capture (working fired with an empty prompt; done never fired). Main's clean-data feed fixes this; the parity harness documents both behaviors.
Validation
Cut-off
Independently mergeable; Phase 3 complete. Phase 4 (gating hidden PTY delivery in main) builds on the four enumerated
subscribeToPtyDatadelivery-interest registrations.Made with Orca 🐋