Conversation
Co-authored-by: Orca <help@stably.ai>
…/term-speed-2-side-effect-channel # Conflicts: # src/main/index.ts # src/main/ipc/settings.test.ts # src/main/runtime/orca-runtime.ts
…/term-speed-2-side-effect-channel
…/term-speed-2-side-effect-channel # Conflicts: # src/shared/agent-detection.ts
…/term-speed-2-side-effect-channel
|
Ready to review this PR? Stage has broken it down into 9 individual chapters for you: Chapters generated by Stage for commit 3bd15ec on Jun 17, 2026 9:34am UTC. |
…/term-speed-2-side-effect-channel
…/term-speed-2-side-effect-channel
…/term-speed-2-side-effect-channel
…/term-speed-2-side-effect-channel
Contributor
Author
|
Closing as superseded by merged PR #7214 (merge e84a8dd), which explicitly revived the complete term-speed-2 model/view chain into current main and then added newer scheduler, producer flow-control, snapshot, and reliability work. This old component/rollup branch no longer has an independent delta to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 slice 2 (design:
docs/reference/terminal-side-effect-authority.md). Terminal side effects for PTYs whose bytes transit main (local-daemon + SSH) are now derived once in the main process and delivered to the renderer as facts, replacing renderer byte parsing for those PTYs.pty:sideEffectchannel: per-chunk facts (title / bell / agent-working / agent-idle / agent-exited) in byte order with attribution + output seq; bell detector lifted tosrc/shared/terminal-bell-detector.tsterminal-side-effect-facts-handler.ts) with exactly-one-consumer-per-PTY semantics, title-only replay snapshots (no historical-bell attention), and a seq guard against snapshot/live racessettings.terminalMainSideEffectAuthority(default on, read synchronously pre-hydration so the kill switch holds at app-restart bindings)pty:datacopy remains until slice 3Review hardening (3-lens adversarial review, all findings fixed with tests)
Validation
Cut-off
Independently mergeable. Slice 3 removes the synthetic
pty:datalegacy copy and adds OSC 133;D + PR-link facts; slice 4 retires the watcher's byte sidecar.Made with Orca 🐋