Conversation
Co-authored-by: Orca <help@stably.ai>
nwparker
force-pushed
the
nwparker/term-speed-2-wake-session-reregister
branch
from
June 10, 2026 00:08
4d5410e to
8cc550e
Compare
nwparker
force-pushed
the
nwparker/term-speed-2-subscribe-recovery-kind
branch
from
June 10, 2026 00:08
3dffe2f to
a4e3001
Compare
…arker/term-speed-2-subscribe-recovery-kind
…arker/term-speed-2-subscribe-recovery-kind
|
Ready to review this PR? Stage has broken it down into 2 individual chapters for you:
Chapters generated by Stage for commit e4bbb86 on Jun 17, 2026 9:10am UTC. |
…arker/term-speed-2-subscribe-recovery-kind
…arker/term-speed-2-subscribe-recovery-kind
…arker/term-speed-2-subscribe-recovery-kind
…arker/term-speed-2-subscribe-recovery-kind
…arker/term-speed-2-subscribe-recovery-kind
Contributor
Author
|
Closing as superseded by merged PR #7214 (merge e84a8dd), which explicitly revived the complete term-speed-2 model/view chain into current main and then added newer scheduler, producer flow-control, snapshot, and reliability work. This old component/rollup branch no longer has an independent delta to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminal.subscribepending-output-overflow recovery snapshot askind: 'resized'instead of a secondkind: 'scrollback'frameseqfrom that wire frame (it is still used server-side for trimming covered pending chunks)Why
The shipped mobile client — the consumer of this stream — unconditionally drops a second
scrollbackevent for an initialized handle, but applies aresizedevent carryingserializedby re-initializing xterm with fresh scrollback. With the oldscrollbackkind, the recovery snapshot introduced in #5025 was discarded client-side while the server had already trimmed the pending chunks it covered — making the visible gap strictly larger than the pre-#5025 behavior (which replayed the retained tail). Omittingseqalso keeps output-byte sequences out of the client's layout-seq staleness filter.For renderer-source snapshots there is no output seq, so covered chunks cannot be trimmed exactly — and under backpressure the renderer view may lag the queued chunks, so "serialized later" does not prove coverage. That path now keeps the bounded replay rather than applying an unverifiable snapshot.
Validation
kind: 'resized',reason: 'pending-output-overflow', with noseqon the wire; new testkeeps bounded replay when overflow recovery has no output seqproves the seq-less path replays the retained tail with no recovery framepnpm exec vitest run --config config/vitest.config.ts src/main/runtime/rpc/terminal-subscribe-buffer.test.ts src/main/runtime/mobile-subscribe-integration.test.tspassed: 50 tests, 2 skippedpnpm exec oxlinton touched files passedpnpm run typecheckpassedgit diff --checkpassedMade with Orca 🐋