Preserve rich formatting on message edits#93
Closed
delaneyb wants to merge 1 commit into
Closed
Conversation
delaneyb
force-pushed
the
fix-edit-formatting
branch
2 times, most recently
from
May 13, 2026 12:32
a873c8b to
812f3cb
Compare
AmethystLiang
self-requested a review
May 21, 2026 03:05
AmethystLiang
added a commit
that referenced
this pull request
May 30, 2026
Merged replacement for #93 after maintainer pushes to the contributor fork were rejected with 403. Included fixes from review: - Keep inline-only edits text-only. - Preserve channel/usergroup/broadcast tokens in rich-text conversion. - Preserve http(s) and mailto manual links. - Keep non-URL angle-bracket tokens literal. - Sync README and bundled agent-slack skill docs. Validation: - bun test - bun run typecheck - bun run format:check - bun run lint - CI Build, Lint, Test passed - Independent xhigh Codex review: no blocking findings
Contributor
|
Thanks for the PR. I reviewed this hard and found a few edge-case regressions in the original head branch (channel/usergroup/manual-link handling and inline-only edit behavior). GitHub rejected maintainer pushes to the contributor fork with 403, so I merged a maintainer replacement PR with the original change plus fixes: #100. Validation on the replacement:
Closing this PR as superseded by #100 / merge commit 94ecafe. |
Contributor
|
Superseded by #100, which includes this PR plus review fixes and has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves supported rich formatting when editing Slack messages via
chat.update, without changing plain text edit behavior.What changed
message editso formatted edits include Slackrich_textblocks.message sendbehavior unchanged.Tests
blocks.<fix>stays escaped text and does not become blocks.<https://example.com|label>send rich-text blocks.Prepared by GPT-5.5 Medium using a custom sub-agent review process.
This change was reviewed by 5 sub-agents:
chat.updateformatting approach.