Conversation
ssalggnikool
requested changes
Jul 10, 2026
Owner
|
this seems to be somewhat buggy, the notification never gets completed/removed after the download finishes, the progress also does not seem to update sometimes, here the download has finished but the notification hasn't gone away and the progress is still at like 5% 
also if a download fails the notification doesn't go away also also downloading multiple songs seems to work correctly, and the notification is updated pretty consistently and properly, it's just that after the final song is downloaded the notification will never go away |
# Conflicts: # composeApp/src/androidMain/kotlin/paige/navic/di/PlatformModule.android.kt # composeApp/src/commonMain/kotlin/paige/navic/domain/manager/DownloadManager.kt # composeApp/src/iosMain/kotlin/paige/navic/di/PlatformModule.ios.kt
ssalggnikool
requested changes
Aug 26, 2026
ssalggnikool
approved these changes
Aug 26, 2026
ssalggnikool
left a comment
ssalggnikool
left a comment
Owner
There was a problem hiding this comment.
this looks pretty good now but can't test it currently
would like to know how it reacts to downloads failing or being cancelled or anything like that
# Conflicts: # composeApp/src/androidMain/kotlin/paige/navic/di/PlatformModule.android.kt # composeApp/src/commonMain/kotlin/paige/navic/domain/manager/DownloadManager.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did what u asked :)
closes #328