Skip to content

Conversation

@srcrip
Copy link
Owner

@srcrip srcrip commented Feb 14, 2025

Thanks to:

For their very helpful contributions!

I think there was a styler update that caused these formatting changes
@srcrip
Copy link
Owner Author

srcrip commented Feb 25, 2025

Sorry for the delay on this, but I updated the formatter before realizing the demo project wasn't on the right version to use the new {} syntax, so it'll be a little delayed while I update the demo project to the latest Phoenix.

@wkirschbaum
Copy link
Contributor

@srcrip are you not able to usemix format --migrate to automatically convert to use the new syntax? maybe I can help out if you wish?

@srcrip
Copy link
Owner Author

srcrip commented Mar 20, 2025

it's all good, it should be fixed now. Sorry it took me a while! the problem was a combination of the formatter thing, but also the formatter broke some tests that cared about newlines in the html elsewhere that wasn't immediately obvious.

@srcrip
Copy link
Owner Author

srcrip commented Mar 20, 2025

actually, one more problem sorry

I don't even remember why I wrote it like that? It's not actually in the
struct. But it also worked before? I have no idea.
@srcrip
Copy link
Owner Author

srcrip commented Mar 20, 2025

ok, for reference, in here I fixed this weird usage of body to reference the text of the toast where everywhere else I called it msg, but for some reason it still worked? It works either way. I have no idea why. I must be double-assigning msg to body somewhere else. That'd be something good to track down and remove.

@srcrip
Copy link
Owner Author

srcrip commented Mar 20, 2025

Anyway I'm full sending this now, as it all seems to work for me.

@srcrip srcrip merged commit 082b36d into master Mar 20, 2025
1 check passed
@wkirschbaum
Copy link
Contributor

@srcrip thanks for the effort. I have spotted one issue with the release: #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants