Skip to content

fix: use Database.Format for SQL escaping instead of manual EscapeString #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rushaway merged 1 commit into from
Aug 27, 2026
Merged

fix: use Database.Format for SQL escaping instead of manual EscapeString #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/sourcemod/scripting/shop.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#tryinclude <SteamWorks>
#define REQUIRE_EXTENSIONS

#define SHOP_VERSION "3.0E9"
#define SHOP_VERSION "3.0E10"
#define SHOP_MYSQL_CHARSET "utf8mb4"

#pragma newdecls required
Expand Down
14 changes: 6 additions & 8 deletions addons/sourcemod/scripting/shop/player_manager.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,9 +1089,8 @@ public void PlayerManager_OnPlayerName(Event event, const char[] name, bool dont
int client = GetClientOfUserId(event.GetInt("userid"));
if (!client || !i_Id[client]) return;

char newname[MAX_NAME_LENGTH*2+1], s_Query[256];
event.GetString("newname", s_Query, sizeof(s_Query));
EscapeString(s_Query, newname, sizeof(newname));
char newname[MAX_NAME_LENGTH], s_Query[256];
event.GetString("newname", newname, sizeof(newname));
h_db.Format(s_Query, sizeof(s_Query), "UPDATE `%splayers` SET `name` = '%s' WHERE `id` = '%i';", g_sDbPrefix, newname, i_Id[client]);
TQueryEx(s_Query, DBPrio_Low);
}
Expand Down Expand Up @@ -1180,10 +1179,9 @@ public void PlayerManager_AuthorizeClient(Database owner, DBResultSet hndl, cons
{
case 0 :
{
char name[MAX_NAME_LENGTH], buffer[65];
char name[MAX_NAME_LENGTH];
GetClientName(client, name, sizeof(name));
EscapeString(name, buffer, sizeof(buffer));


char s_Query[256];
if (!hndl.FetchRow())
{
Expand All @@ -1193,7 +1191,7 @@ public void PlayerManager_AuthorizeClient(Database owner, DBResultSet hndl, cons
dp.WriteCell(1);
dp.WriteCell(g_iStartCredits);

h_db.Format(s_Query, sizeof(s_Query), "INSERT INTO `%splayers` (`name`, `auth`, `money`, `lastconnect`) VALUES ('%s', '%s', '%d', '%d');", g_sDbPrefix, buffer, auth, g_iStartCredits, global_timer);
h_db.Format(s_Query, sizeof(s_Query), "INSERT INTO `%splayers` (`name`, `auth`, `money`, `lastconnect`) VALUES ('%s', '%s', '%d', '%d');", g_sDbPrefix, name, auth, g_iStartCredits, global_timer);
TQuery(PlayerManager_AuthorizeClient, s_Query, dp);

return;
Expand All @@ -1204,7 +1202,7 @@ public void PlayerManager_AuthorizeClient(Database owner, DBResultSet hndl, cons
iCredits[client] = hndl.FetchInt(0);
i_Id[client] = hndl.FetchInt(1);

h_db.Format(s_Query, sizeof(s_Query), "UPDATE `%splayers` SET `name` = '%s', `lastconnect` = '%d' WHERE `id` = '%i';", g_sDbPrefix, buffer, global_timer, i_Id[client]);
h_db.Format(s_Query, sizeof(s_Query), "UPDATE `%splayers` SET `name` = '%s', `lastconnect` = '%d' WHERE `id` = '%i';", g_sDbPrefix, name, global_timer, i_Id[client]);
TQueryEx(s_Query);

PlayerManager_LoadClientToggles(client);
Expand Down