chore(ci): replace SourceKnight with setup-sp - #23
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow that usesrumblefrog/setup-spto compile the plugin directly withspcomp, following the same job structure already validated insrcdslab/sm-plugin-AdminRoom.Plugin targets
addons/sourcemod/scripting/FixSvGravity.spaddons/sourcemod/plugins/FixSvGravity.smxDependencies
https://sm.alliedmods.net/smdrop/1.11/sourcemod-1.11.0-git6917-linux.tar.gz(type: tar)/addons→/addons(not needed in new CI — replaced byrumblefrog/setup-spwith SourceMod 1.12.x)This plugin declared no
type: gitdependencies insourceknight.yaml, so the new workflow has no dependency-clone step.Changes
.github/workflows/ci.ymlwithbuild/tag/releasejobs mirroring the AdminRoom reference (SourceMod pinned to1.12.xviarumblefrog/setup-sp).sourceknight.yaml..github/copilot-instructions.mdto describe the native GitHub Actions build instead of SourceKnight..sourceknight/.venventries from.gitignore..smxintoaddons/sourcemod/plugins/inside the artifact; noconfigs/,translations/, or other extra directories exist in this repo's tree, so nothing else is packaged.Not locally validated
This PR was prepared without cloning dependencies or running
spcomplocally (lightweight migration pass). The actual compile is not verified locally — this relies on the CI run itself (GitHub Actionsbuildjob) to confirm the plugin compiles successfully with SourceMod 1.12.x.Manual verification needed
configs/,translations/, or other asset directories were found in the repository tree at migration time, so the package step only includes the compiled.smx. Please confirm this is complete once CI runs.