ci: replace SourceKnight with native GitHub Actions workflow - #42
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the BossHP plugin’s CI/CD pipeline away from SourceKnight to an explicit GitHub Actions workflow that installs dependencies and compiles BossHP.sp with spcomp, then packages and publishes release artifacts.
Changes:
- Replaced the SourceKnight build step with a
rumblefrog/setup-sp+spcompbuild and explicit dependency cloning/copying. - Updated packaging/release jobs and removed
sourceknight.yaml. - Updated repo hygiene/docs to drop SourceKnight references (e.g.,
.gitignore, Copilot instructions).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Replaces SourceKnight CI with native steps for dependency install, compilation, packaging, tagging, and releasing. |
sourceknight.yaml |
Removed the deprecated SourceKnight configuration. |
.gitignore |
Stops ignoring .sourceknight artifacts and ignores the new deps/ directory used by CI/local builds. |
.github/copilot-instructions.md |
Updates documentation to reflect the new GitHub Actions-based build system and compiler setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+41
to
+43
| mkdir -p /tmp/package/addons/sourcemod/plugins | ||
| cp addons/sourcemod/plugins/*.smx /tmp/package/addons/sourcemod/plugins/ | ||
| cp -R addons/sourcemod/configs /tmp/package/addons/sourcemod/ |
Comment on lines
16
to
20
| - **Language**: SourcePawn (.sp files) | ||
| - **Platform**: SourceMod 1.11.0+ (latest stable release) | ||
| - **Build System**: SourceKnight (sourceknight.yaml) | ||
| - **Compiler**: SourcePawn compiler (spcomp) via SourceKnight | ||
| - **Build System**: Native GitHub Actions (.github/workflows/ci.yml) | ||
| - **Compiler**: SourcePawn compiler (spcomp) via rumblefrog/setup-sp | ||
| - **Dependencies**: outputinfo extension, smlib, basic plugin, multicolors |
Rushaway
force-pushed
the
chore/drop-sourceknight
branch
from
August 18, 2026 11:16
dfb5120 to
4bd5007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow, matching the validated structure already rolled out to othersrcdslabplugins (reference:srcdslab/sm-plugin-AdminRoom).spcompviarumblefrog/setup-sp@v1.3.1pinned to SourceMod1.12.x(repo'ssourceknight.yamldeclared1.12.0-git7223).--depth=1and copies its real include path in explicitly (no build-tool magic)..smxunderaddons/sourcemod/plugins/plusaddons/sourcemod/configs/(map configs, unchanged from before).tag/releasejob structure,ifconditions, and action pins copied verbatim from the AdminRoom reference, including its three previously-fixed bugs (tag job checkout isactions/checkout@v7first step; releaseifgates onneeds.tag.resultbeingsuccessorskipped; dependency-installmkdir -pcreates thedepsdir itself, not just the includes dir).sourceknight.yamland updated.github/copilot-instructions.md/.gitignoreto drop remaining SourceKnight references.Plugin targets compiled
addons/sourcemod/scripting/BossHP.spDependencies cloned
package/addons/sourcemod/scripting/include/outputinfo.incaddons/sourcemod/scripting/include/smlib.inc(+smlib/*.inc)addons/sourcemod/scripting/include/basic.incaddons/sourcemod/scripting/include/multicolors.inc(+multicolors/*.inc)All four matched the paths declared in the old
sourceknight.yamlafter verifying against the real cloned repos (no non-standard nesting found here).Local validation performed
spcomp(SourcePawn Compiler 1.12.0.7246) matching the repo's declared SM 1.12 branch.--depth=1into a scratchdeps/directory and copied their include folders intoaddons/sourcemod/scripting/include/, replicating exactly what the new CI workflow's "Install dependencies" step does.BossHP.spwithspcomp -i include -o ../plugins/BossHP.smx BossHP.spfromaddons/sourcemod/scripting, replicating the new workflow's "Build sourcemod plugin" step.smlibinclude (unused symbol / sizeof-on-scalar), no errors. ProducedBossHP.smx(43,639 bytes).Manual verification needed
🤖 Generated with Claude Code