Document product attributes and Apply to vs Apply when in discounts - #3893
Merged
Merged
Conversation
✅ Deploy Preview for spryker-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
profuel
reviewed
Sep 8, 2026
profuel
reviewed
Sep 8, 2026
profuel
reviewed
Sep 8, 2026
profuel
reviewed
Sep 8, 2026
profuel
reviewed
Sep 8, 2026
profuel
reviewed
Sep 8, 2026
profuel
reviewed
Sep 8, 2026
profuel
reviewed
Sep 8, 2026
profuel
previously approved these changes
Sep 8, 2026
Addresses user feedback that critical information was missing from the Promotions & Discounts documentation. Product attributes in decision rules: - Explain that attribute fields are named `attribute.<attribute_key>` and are generated from the product attribute keys that exist in your database, so no attribute keys means no attribute fields. - Link to creating attributes in the Back Office and to the `product-attribute-key` data import. - Point out that `attribute.color` and `attribute.processor_cores` are examples that may not exist in your database, depending on the demo shop you started with. - Add the missing `list` value type to the `attribute.*` reference row, document which operators each field offers, and note that costly operators are left out for performance reasons. Apply to compared to Apply when: - Document that these are two separate settings: Apply when gates whether the discount applies to the cart, Apply to selects which items receive it. - Note that Apply to offers only item-level fields while Apply when also offers cart-level and customer-level fields, and that fields present in both have a different meaning in each. - Rewrite the "Decision rule" section to lead with the Back Office wording, since the Back Office only uses the Apply when and Apply to labels. The headings and anchors are unchanged so existing links keep working. - Add screenshots of both tabs showing the same rule. Image fixes: - Replace query-builder.png, which showed `sku equal *` while the surrounding text described `total-quantity = 3 AND day-of-week = 5`, contradicting both the prose and the paired plain query screenshot. - Replace query-string.png, which showed the removed "Discount collection type" and "Discount promotion to product" labels instead of the current "Discount application type" and "PROMOTIONAL PRODUCT". - Give both images descriptive alt text. Field lists, operator lists and UI labels were verified against a running B2B demo shop.
feversocial
force-pushed
the
docs/discount-attributes-apply-to-when
branch
from
September 15, 2026 09:27
517f79c to
5295466
Compare
profuel
enabled auto-merge (squash)
September 15, 2026 14:49
profuel
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses user feedback that critical information was missing from the Promotions & Discounts documentation.
Product attributes in decision rules:
attribute.<attribute_key>and are generated from the product attribute keys that exist in the project, so no attribute keys means no attribute fields.product-attribute-keydata import.attribute.colorandattribute.processor_coresin the examples as illustrative, since they are project-specific and not present by default.listvalue type to theattribute.*reference row and document which operators each field offers, so a shorter operator list is explainable rather than surprising.Apply to compared to Apply when:
Image fixes:
sku equal *while the surrounding text describedtotal-quantity = 3 AND day-of-week = 5, contradicting both the prose and the paired plain query screenshot.Field lists, operator lists and UI labels were verified against a running B2B demo shop.
PR Description
Describe the context for your changes and the changes you've made.
Tickets
If changes are associated with a ticket, add a docs ticket here.
Checklist