Repository navigation
Drop the Android-only vendored OpenSSL - #718
Open
theosirian wants to merge 1 commit into
Open
theosirian wants to merge 1 commit into
theosirian wants to merge 1 commit into
Conversation
Remove the `[target.'cfg(target_os = "android")'.dependencies.reqwest]` overrides with `native-tls-vendored` from ssi-dids-core, did-ion, did-tz, did-web and ssi-vc. reqwest already uses rustls here, and the overrides vendor a full OpenSSL (QUIC included) into every Android app that depends on ssi.
sbihel
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ssi-dids-core,did-ion,did-tz,did-webandssi-vchave an Android-only reqwestoverride with
native-tls-vendored. These crates already use rustls; the override stillbuilds and links a full vendored OpenSSL 3.6 (QUIC included) into every Android app that depends
on
ssi, and turns reqwest's default features back on. In SpruceKit Mobile, OpenSSL and thesecond HTTP/TLS stack around it cost several MB of the Android
.so.History
The override came in with #120 (re-merged as #127, March 2021), when
did-webanddid-tezosmoved to reqwest 0.11 with default features: their default TLS was
native-tls, and Android'sNDK has no OpenSSL to link, so it was vendored to make Android builds compile. #484 (November
2022, "Remove openssl") switched these crates to
default-features = false+rustls-tls,which removed the need, but left the Android-only blocks in place; they were later copied into
new crates and kept through the refactor (#508) and the reqwest upgrade (#702).
This removes the five override blocks. Manifest-only; no API change.
Behaviour on Android
With the override gone, Android uses the same reqwest 0.13
rustlsbackend as every otherplatform: aws-lc-rs, with certificates checked by
rustls-platform-verifieragainst the devicetrust store. On Android, that verifier has to be initialised once with a JVM and an application
Context(rustls_platform_verifier::android::init_with_env, plus its Kotlin component) beforethe first HTTPS request; otherwise that request panics. Apps that resolve
did:web,did:tzordid:ion, or fetch status lists, on Android need that step. SpruceKit Mobile adds it in its SDK(an AndroidX Startup initializer).
Tested
cargo test --lib --tests -p ssi-dids-core -p did-ion -p did-tz -p did-web -p ssi-vc -p ssi-status:80 passed, 0 failed.