Optimize the usage of JacksonMongoSessionConverter to prevent duplica…#3187
Open
xiaoquanidea wants to merge 1 commit intospring-projects:mainfrom
Open
Optimize the usage of JacksonMongoSessionConverter to prevent duplica…#3187xiaoquanidea wants to merge 1 commit intospring-projects:mainfrom
xiaoquanidea wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Author
rwinch
requested changes
Oct 21, 2024
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR. Generally, please only make the changes necessary (e.g. no changing of scopes or import ordering), ensure the build passes.
Also this PR should be based off of main since it is a new feature.
...ngodb/src/main/java/org/springframework/session/data/mongo/JacksonMongoSessionConverter.java
Show resolved
Hide resolved
…te MongoSession Document saves when a custom ObjectMapper is provided.spring-projects#3185
xiaoquanidea
force-pushed
the
feature/jackson
branch
from
2ae93cb to
ff90e4e
Compare
Author
Thank you for the reminder. I have resubmitted the code as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…te MongoSession Document saves when a custom ObjectMapper is provided.#3185