Add opt-out for default RestClient status handler#36251
Open
seungy0 wants to merge 1 commit intospring-projects:mainfrom
Open
Add opt-out for default RestClient status handler#36251seungy0 wants to merge 1 commit intospring-projects:mainfrom
seungy0 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Seunggyu Lee <dltmdrb98@gmail.com>
seungy0
referenced
this pull request
in LavaC3/spring-framework
Feb 4, 2026
|
@seungy0 🙏 I realize my previous implementation had an oversight (didn't consider the built-in StatusHandler logic in DefaultResponseSpec), and your solution with a dedicated disable flag passed to DefaultResponseSpec is definitely the right and complete approach. It's a great learning for me to dive into the RestClient source code and Spring contribution process through this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce an explicit opt-out for the built-in default RestClient status handler (4xx/5xx → exception).
This allows users to fully control status handling without the “always-match” workaround.
Motivation
Related issue: #36248
Changes
RestClient.Builder#disableDefaultStatusHandler()(default behavior unchanged).Tests
DefaultRestClientTests.defaultStatusHandlerThrowsOnErrorStatusDefaultRestClientTests.disableDefaultStatusHandlerAllowsErrorBodyRestClientBuilderTests.disableDefaultStatusHandlerNotes
Backward compatible. Opt-in only.