Skip to content

Honor currentItemCount when saveState is disabled - #5650

Open
lim950808 wants to merge 1 commit into
spring-projects:mainfrom
lim950808:honor-current-item-count-without-save-state
Open

lim950808 wants to merge 1 commit into
spring-projects:mainfrom
lim950808:honor-current-item-count-without-save-state

Conversation

@lim950808

Copy link
Copy Markdown

AbstractItemCountingItemStreamItemReader#open returned early when saveState was disabled, so an explicitly set currentItemCount was never applied (the counter starts at the given value but the reader does not move). With JdbcCursorItemReader this fails with "Unexpected cursor position change".

The execution context is still ignored when saveState is disabled.

Note: JdbcPagingItemReader still cannot jump beyond the first page without the start-after values (this already fails with saveState enabled). I can address that separately.

Resolves #1227

Resolves spring-projects#1227

Signed-off-by: Jae Eok Lim <lim080895@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RepositoryItemReader currentItemCount is ignored (page starts at 0) when SaveState(false) [BATCH-2377]

1 participant