Handle missing Eureka AMI metadata#4565
Open
pony-maggie wants to merge 1 commit into
Open
Conversation
Fixes spring-cloudgh-3703 Signed-off-by: Lucas Ma <7184042+pony-maggie@users.noreply.github.com>
pony-maggie
force-pushed
the
fix-eureka-dashboard-ami-column
branch
from
274aa35 to
efa2f84
Compare
Author
|
Rebased on latest Verified locally: JAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -pl spring-cloud-netflix-eureka-server -Dtest=EurekaControllerTests#statusUsesDefaultAmiForAmazonInstancesWithoutAmiMetadata test -P spring -nsu --batch-modeResult: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-3703
This PR keeps the Eureka dashboard AMI fallback when an Amazon instance does not include the
ami-idmetadata value. It also avoids a null availability-zone key for the same dashboard count model.Tests:
JAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -pl spring-cloud-netflix-eureka-server -Dtest=EurekaControllerTests#statusUsesDefaultAmiForAmazonInstancesWithoutAmiMetadata test -P spring -nsu --batch-modeJAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -pl spring-cloud-netflix-eureka-server -Dtest=EurekaControllerTests test -P spring -nsu --batch-modeJAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -pl spring-cloud-netflix-eureka-server test -P spring -nsu --batch-mode