Skip to content

fix(HYBIM-849): rename local variables to avoid shadowing#95

Open
shuningc wants to merge 1 commit into
mainfrom
HYBIM-849-fix_shadowing_test_setup
Open

fix(HYBIM-849): rename local variables to avoid shadowing#95
shuningc wants to merge 1 commit into
mainfrom
HYBIM-849-fix_shadowing_test_setup

Conversation

@shuningc

Copy link
Copy Markdown
Contributor

Summary

  • Rename version → py_version in test_setup.py to avoid shadowing the outer version name
  • Rename log → logger_instance in experiments.py to avoid shadowing the module-level _logger
  • Rename version → version_str in headers_data.py to avoid shadowing the imported version from get_package_version()

@shuningc
shuningc requested a review from fercor-cisco July 16, 2026 22:57

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: approve — Purely local-variable renames to remove shadowing; all references updated correctly and no behavior change.

General Comments

  • 🔵 nit (documentation): The PR description states the loglogger_instance rename avoids "shadowing the module-level _logger", but the local log actually shadowed the imported log decorator from splunk_ao.decorator (imported at experiments.py line 14, used at line 246), not _logger. The rename itself is correct and beneficial — only the stated rationale is inaccurate. Worth correcting in the description to avoid future confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants